feat: support more ssl verify mode#3141
Merged
Merged
Conversation
added 2 commits
November 6, 2025 17:31
zchuango
pushed a commit
to zchuango/brpc
that referenced
this pull request
May 9, 2026
* feat: support more ssl verify mode * 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: resolve
#297
Problem Summary:
Previously, after setting verify_depth, the default behavior was to use only the verification mode SSL_VERIFY_PEER | SSL_VERIFY_FAIL_IF_NO_PEER_CERT. It was not possible to use SSL_VERIFY_PEER alone. Therefore, we needed to add additional configuration to control this behavior. For this reason, a VerifyMode field was added to VerifyOptions, corresponding to the content of sslverify. Since OpenSSL’s verify options are defined as macros, the SSL_ prefix was removed to distinguish them.
What is changed and the side effects?
Changed:
The verify mode set in sslctx when verify_depth > 0
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: